Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process or reject more complex Podfile situations #562

Closed
brunobowden opened this issue Oct 30, 2015 · 0 comments
Closed

Process or reject more complex Podfile situations #562

brunobowden opened this issue Oct 30, 2015 · 0 comments

Comments

@brunobowden
Copy link
Contributor

It may not be possible for plugin to effectively parse and update the Podfile - particularly when it includes complex ruby scripts. In this situation the plugin should:

  1. Identify when it's a non-standard more complex Podfile
  2. Process the Podfile if possible
  3. If not possible to process, then fail the build with warning about disabling this with Config to only add j2objc_shared method to Podfile and not update targets #561

Example Podfile from this discussion:
https://groups.google.com/forum/#!topic/j2objc-discuss/crJsUkozk3Q

post_install do |installer|
  target = installer.project.targets.find{|t| t.to_s == "Pods-MagicalRecord"}
    target.build_configurations.each do |config|
        s = config.build_settings['GCC_PREPROCESSOR_DEFINITIONS']
        s = [ '$(inherited)' ] if s == nil;
        s.push('MR_ENABLE_ACTIVE_RECORD_LOGGING=0') if config.to_s == "Debug";
        config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] = s
    end
end
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Jan 10, 2016
- Manual config mode for Xcode targets in Podfile
- FAQ to explain how to use this
- Better "DO NOT MODIFY" lines for "pod method" + upgrade logic
- Fixes j2objc-contrib#561
- Fixes j2objc-contrib#562
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Jan 12, 2016
- Manual config mode for Xcode targets in Podfile
- FAQ to explain how to use this
- Better "DO NOT MODIFY" lines for "pod method" + upgrade logic
- Fixes j2objc-contrib#561
- Fixes j2objc-contrib#562
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Jan 12, 2016
- Manual config mode for Xcode targets in Podfile
- FAQ to explain how to use this
- Better "DO NOT MODIFY" lines for "pod method" + upgrade logic
- Fixes j2objc-contrib#561
- Fixes j2objc-contrib#562
brunobowden added a commit to brunobowden/j2objc-gradle that referenced this issue Jan 12, 2016
- Manual config mode for Xcode targets in Podfile
- FAQ to explain how to use this
- Better "DO NOT MODIFY" lines for "pod method" + upgrade logic
- Fixes j2objc-contrib#561
- Fixes j2objc-contrib#562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant