Fix various reloading issues in debug and production modes #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the ServletContextResourceReaderHandler. There was only one resourceInfoProvider which is a BaseServletContextResourceReader and it does not implement ResourceGenerator Fix issues with child bundles being included instead of parent bundle because parent bundleId was being used. Ensure config change event doesn't occur on first check of configChanged. Stop listeners and watchers and create anew after config change to ensure the bundlesHandler is consistent between the resource watcher and the rebuilding of dirty bundles in JawrRequestHandler
This was referenced Jun 16, 2017
…siteBundlePathMappingBuilder logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hotswapping of LESS files by ensuring the file path is returned from the ServletContextResourceReaderHandler. There was only one resourceInfoProvider which is a BaseServletContextResourceReader and it does not implement ResourceGenerator
Fix issues with child bundles being included instead of parent bundle because parent bundled was being used.
Ensure config change event doesn't occur on first check of configChanged.
Stop listeners and watchers and create anew after config change to ensure the bundlesHandler is consistent between the resource watcher and the rebuilding of dirty bundles in JawrRequestHandler