-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated resources (SASS, less, ...) are not updated in debug mode #43
Comments
Hi, Jawr use a cache new cache feature in the 3.9 version. Can you give me more detail about your development configuration? Cheers, |
it looks like setting the cache setting did the trick :) awesome thanks! just for reference: |
Hi, The cache setting was a work around. |
ah okay |
Hey, although it was intended as workaround, caching shouldn't be active in debug mode. No matter if this property is set to As we faced the same problem here with LESS CSS I need to update all projects setting the generator cache to false. |
I don't see why caching shouldn't be active in debug mode. It's simply that the cache needs to be properly updated. I will be adding a pull request soon for some changes that made it work for me, but I don't know if it is correct. Basically, the ServletContextResourceReaderHandler.getFilePath method is returning null because it only has one resourceInfoProvider which is a BaseServletContextResourceReader. That BaseServletContextResourceReader does not implement ResourceGenerator and therefore skips over the block that would return the filePath. |
Hi, It should work in debug mode. Your pull request is welcome :-) Cheers, |
Okay, here is the pull request #53. The isDirectory method looks a little fishy as well. |
Totally separate concern, but while I have your attention I'll ask. Is there going to be a replacement for the java.net project pages which have been taken offline by Oracle? |
Anyway we can get this in soon or some similar version so I don't have to
fork JAWR for my project's purposes?
…On Wed, May 24, 2017 at 9:53 AM, Ibrahim Chaehoi ***@***.***> wrote:
Hi,
It should work in debug mode.
There was an issue, which I didn't get time to fix.
I think that the behaviour that you've presented should be the root cause
of this issue.
Your pull request is welcome :-)
Cheers,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVRZgdkmGKshjNnc5oLBllQ-T0h19poks5r9DZwgaJpZM4KShkg>
.
|
Hi @maximmold I'll try to release a version for the end of July with this fix. Cheers, |
Updating pull request to only include this one change: #57 |
Hi, This issue has been fixed in the master branch. @maximmold : |
When running the vaadin compiler the sass files are not being updated while in debug mode on the fly in 3.9
this works fine in 3.8
The text was updated successfully, but these errors were encountered: