Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated resources (SASS, less, ...) are not updated in debug mode #43

Closed
ghost opened this issue Oct 10, 2016 · 13 comments
Closed

Generated resources (SASS, less, ...) are not updated in debug mode #43

ghost opened this issue Oct 10, 2016 · 13 comments
Milestone

Comments

@ghost
Copy link

ghost commented Oct 10, 2016

When running the vaadin compiler the sass files are not being updated while in debug mode on the fly in 3.9

this works fine in 3.8

@ic3fox
Copy link
Collaborator

ic3fox commented Oct 28, 2016

Hi,

Jawr use a cache new cache feature in the 3.9 version.
You could disable it by using the following property in your jawr properties file :
jawr.use.generator.cache=false

Can you give me more detail about your development configuration?
Which IDE are you using, which application server?
Are the file updated in your web application folder or in a jar file?

Cheers,

@ghost
Copy link
Author

ghost commented Oct 28, 2016

it looks like setting the cache setting did the trick :)

awesome thanks!

just for reference:
i'm using IntelliJ IDE
Tomcat 7 with JDK 1.7 and maven
and the files are being updated in web application folder.

@ghost ghost closed this as completed Oct 28, 2016
@ic3fox ic3fox reopened this Oct 31, 2016
@ic3fox
Copy link
Collaborator

ic3fox commented Oct 31, 2016

Hi,

The cache setting was a work around.
It should have work without it.
I'll take a look to it.

@ghost
Copy link
Author

ghost commented Oct 31, 2016

ah okay

@dtrunk90
Copy link
Contributor

Hey,

although it was intended as workaround, caching shouldn't be active in debug mode. No matter if this property is set to true or false.

As we faced the same problem here with LESS CSS I need to update all projects setting the generator cache to false.

@maximmold
Copy link
Contributor

I don't see why caching shouldn't be active in debug mode. It's simply that the cache needs to be properly updated. I will be adding a pull request soon for some changes that made it work for me, but I don't know if it is correct. Basically, the ServletContextResourceReaderHandler.getFilePath method is returning null because it only has one resourceInfoProvider which is a BaseServletContextResourceReader. That BaseServletContextResourceReader does not implement ResourceGenerator and therefore skips over the block that would return the filePath.

@ic3fox
Copy link
Collaborator

ic3fox commented May 24, 2017

Hi,

It should work in debug mode.
There was an issue, which I didn't get time to fix.
I think that the behaviour that you've presented should be the root cause of this issue.

Your pull request is welcome :-)

Cheers,

@maximmold
Copy link
Contributor

maximmold commented May 24, 2017

Okay, here is the pull request #53. The isDirectory method looks a little fishy as well.

@maximmold
Copy link
Contributor

Totally separate concern, but while I have your attention I'll ask. Is there going to be a replacement for the java.net project pages which have been taken offline by Oracle?

@maximmold
Copy link
Contributor

maximmold commented Jun 9, 2017 via email

@ic3fox
Copy link
Collaborator

ic3fox commented Jun 10, 2017

Hi @maximmold

I'll try to release a version for the end of July with this fix.
Until then, you'll have to use your fork version on your project.

Cheers,

@maximmold
Copy link
Contributor

Updating pull request to only include this one change: #57

@ic3fox ic3fox changed the title SASS files not updating in debug mode Generated resources (SASS, less, ...) are not updated in debug mode Jul 13, 2017
ic3fox added a commit that referenced this issue Jul 13, 2017
Generated resources (SASS, less, ...) are not updated in debug mode
@ic3fox
Copy link
Collaborator

ic3fox commented Jul 13, 2017

Hi,

This issue has been fixed in the master branch.
Thanks to @maximmold for his analysis and the PR.

@maximmold :
Sorry but I've missed your message about the Jawr site.
Yes, the java.net site has been taken offline and the new official Jawr website is on github : https://j-a-w-r.github.io/

@ic3fox ic3fox closed this as completed Jul 13, 2017
@ic3fox ic3fox added this to the 3.10 milestone Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants