flatten() function #1462
Closed
flatten() function #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into flatten()-function
djl11
reviewed
Jun 17, 2022
| shape = 1 | ||
| for dim in x.shape: | ||
| shape *= dim | ||
| return tf.reshape(x, shape) |
There was a problem hiding this comment.
Does TensorFlow not support tf.reshape(x, -1)?
There was a problem hiding this comment.
If it does not, you can do this in one line like so:
import math
tf.reshape(x, math.prod(x.shape))
There was a problem hiding this comment.
In fact. tf.reshape will do the job
djl11
suggested changes
Jun 17, 2022
Closed
|
Will reopen and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djl11
Couldn't find
flatten(). If it is implemented with a different name then i will close this.If you think this is good addition then i will write up some docstring and typehints and fix the test.
Just felt it was needed at times...