Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy.flatten #3161

Closed
5hv5hvnk opened this issue Aug 17, 2022 · 3 comments
Closed

ivy.flatten #3161

5hv5hvnk opened this issue Aug 17, 2022 · 3 comments
Assignees
@ankitdsi2010 @iamjameskeane
Labels
Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task

Comments

@5hv5hvnk
Copy link
Contributor

ivy codebase lacks ivy.flatten method to flatten a matrix or a tensor which I feel is relevant for a lot of frontend/backend methods that would be added in future
@iamjameskeane
Copy link
Contributor

Hi @5hv5hvnk,

Thanks for flagging, I will mention to the team!

I will leave this issue open and report back :)

@iamjameskeane iamjameskeane linked a pull request Aug 24, 2022 that will close this issue
flatten() function #1462
Closed
@iamjameskeane
Copy link
Contributor

Hi,

I have linked the issue to a PR that was working on an implementation for ivy.flatten. Once this PR has been merged this issue will be closed.

Thanks for Flagging!

@ahmedo42 ahmedo42 added Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Aug 31, 2022
@ahmedo42 ahmedo42 changed the title Create ivy.flatten ivy.flatten Aug 31, 2022
@johanjino
Copy link
Contributor

We have discussed internally, and we have accepted that this function should be added to Ivy's functional API. This item has been added to our ongoing Ivy Extension issue. Therefore, this issue will now be closed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitdsi2010 ankitdsi2010

@iamjameskeane iamjameskeane

Labels
Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flatten() function Ishticode/ivy
5 participants
@5hv5hvnk @ahmedo42 @ankitdsi2010 @iamjameskeane @johanjino