Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Localization for trending iv-org#331 #2529

Merged
merged 6 commits into from
Oct 26, 2021
Merged

Feature Request: Localization for trending iv-org#331 #2529

merged 6 commits into from
Oct 26, 2021

Conversation

DmitrySandalov
Copy link
Contributor

@DmitrySandalov DmitrySandalov commented Oct 21, 2021

Closes #331

  1. If a region is set in the URL region=JP (like this), it will be used first
  2. Alternatively if a region is set in preferences UI, it will be used next
  3. If not set in URL and preferences, then the config.yml will be used
  4. If not set in 1-3, then the default value is assigned region=US

The preferences UI has a dropdown now with the list of available content regions. (I've used REGIONS first, but most of them gave 500 internal error. So, I've tested it with a script and set TRENDING_REGIONS which do not give 500 error.)

image

config/config.example.yml Outdated Show resolved Hide resolved
src/invidious/videos.cr Outdated Show resolved Hide resolved
@SamantazFox
Copy link
Member

I'm deploying this on https://test.invidious.io

@SamantazFox SamantazFox added the in-testing This feature has been deployed and is being tested label Oct 25, 2021
@DmitrySandalov
Copy link
Contributor Author

I've tested the feature on https://test.invidious.io. Working as expected for me. (Was obviously not able to check default_user_preferences).

@SamantazFox
Copy link
Member

Was obviously not able to check default_user_preferences.

I've set the region in the config to DE. I confirm that it works!

@SamantazFox SamantazFox requested review from syeopite and removed request for unixfox and TheFrenchGhosty October 26, 2021 14:16
@SamantazFox
Copy link
Member

SamantazFox commented Oct 26, 2021

Could you please rebase your changes? Sorry for the inconvenience, I had to merge large PRs :)

Nevermind, I could do it, so I did!

@SamantazFox SamantazFox merged commit 2b81a82 into iv-org:master Oct 26, 2021
@SamantazFox
Copy link
Member

thanks for your contribution to invidious @DmitrySandalov :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Localization for trending
2 participants