Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options support for discord.js adapter methods #39

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

domin-mnd
Copy link
Collaborator

This pull request should resolve #36 & #38 by implementing options argument for adapter methods and removing edit/delete validation.

Although PR is backwards compatible, there's a single somewhat breaking change & some codebase questions.

A breaking change would be channel renderer alternatively requiring Message event for reply to work

private createChannelRenderer(
  event: string | Discord.Message,
  opts?: SendOptions,
) {
  // ...

I'm not sure if I need to make changes to ChannelMessageRenderer to add reply method. At the moment, validation executes inside send method.

@domin-mnd
Copy link
Collaborator Author

I did not deprecate abstract ephemeralReply in Reacord class as I don't know if I should

@itsMapleLeaf
Copy link
Owner

Thanks for this! I'll take a proper look later

@domin-mnd
Copy link
Collaborator Author

Feel free to request or make changes 👍

Copy link
Owner

@itsMapleLeaf itsMapleLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has made me think a lot about how to improve the public interface, and I might make my own tweaks later, but these changes are definitely good enough for now!

@itsMapleLeaf itsMapleLeaf merged commit 9aec87a into itsMapleLeaf:main Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support editing ephemeral messages
2 participants