Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reacord.reply for non-interaction events #38

Closed
domin-mnd opened this issue Oct 18, 2023 · 4 comments
Closed

reacord.reply for non-interaction events #38

domin-mnd opened this issue Oct 18, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@domin-mnd
Copy link
Collaborator

Hello, I was wondering if there is any internal support for message.reply() (not the interaction.reply()) in discord.js adapter. I spent some time exploring reacord's codebase and so far I've found out that a send method may support options or may be somewhat rewritten to expose adapter's internals to make changes:

const message = await channel.send(getDiscordMessageOptions(options))

The question is: can I use message.reply() instead of message.send() for message event?

@itsMapleLeaf
Copy link
Owner

This is not yet supported, but it definitely could be. It'll probably be a good idea to add an options object to ReacordDiscordJs#send

@itsMapleLeaf itsMapleLeaf added enhancement New feature or request help wanted Extra attention is needed labels Oct 18, 2023
@domin-mnd
Copy link
Collaborator Author

Do we need ephemeralReply as a method in adapter? Ephemeral state may become an option in reply method. Other than that, should these methods be explicitly set in adapter as was mentioned in Reacord class?

abstract send(...args: unknown[]): ReacordInstance
abstract reply(...args: unknown[]): ReacordInstance
abstract ephemeralReply(...args: unknown[]): ReacordInstance

I'd like to open a pull request but I'm not sure what options argument should have besides the asReply or reply option.

@itsMapleLeaf
Copy link
Owner

itsMapleLeaf commented Oct 18, 2023

ephemeralReply existed initially because normal replies and ephemeral replies had a lot of differences, but I don't think that's true anymore, so we should probably deprecate it tbh

  /** 
   * @deprecated Use reacord.reply(content, { ephemeral: true })
   */
  abstract ephemeralReply(...args: unknown[]): ReacordInstance

@domin-mnd
Copy link
Collaborator Author

Resolved, see #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants