Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast: Prevent error being thrown if opened without returnElements setting #572

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Toast: Prevent error being thrown if opened without returnElements setting #572

merged 5 commits into from
Aug 2, 2023

Commits on Jul 28, 2023

  1. test(toast): run tests with default returnElements 

    The toaster element should be defaulting to an empty
array if no returnElements is passed in.
    @brentswisher
    brentswisher committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3e471c2 View commit details
    Browse the repository at this point in the history

  2. fix(toast): ensure returnElements is defined 

    If a custom event was fired without a returnElement, it was
setting the private attribute to undefined. This would
throw an error on toast close because it was not iterable.
    @brentswisher
    brentswisher committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    db05759 View commit details
    Browse the repository at this point in the history

  3. docs: add @brentswisher as a contributor

    @brentswisher
    brentswisher committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2af6aa5 View commit details
    Browse the repository at this point in the history

  4. chore(changelog): update changelog

    @brentswisher
    brentswisher committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7e460f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge branch 'develop' into bugfix/prevent-undefined-toast-return-ele… 

    …ments
    @brentswisher
    brentswisher authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    793c910 View commit details
    Browse the repository at this point in the history