Toast: Prevent error being thrown if opened without returnElements setting #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toaster element should be defaulting to an empty array if no returnElements is passed in.
If a custom event was fired without a returnElement, it was setting the private attribute to undefined. This would throw an error on toast close because it was not iterable.
brentswisher
requested review from
SMQuazi,
drewgingerich and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: 793c910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
chrisjbrown
approved these changes
Jul 31, 2023
daneah
reviewed
Jul 31, 2023
I updated the existing mock to not pass an explicit I changed the test first, saw it failing, made my change, saw it passing so I do think it is covering the changes. Not opposed to adding one though, if you think that would be better? |
That seems sufficient! |
daneah
approved these changes
Jul 31, 2023
Merged
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
…tting (ithaka#572) * test(toast): run tests with default returnElements The toaster element should be defaulting to an empty array if no returnElements is passed in. * fix(toast): ensure returnElements is defined If a custom event was fired without a returnElement, it was setting the private attribute to undefined. This would throw an error on toast close because it was not iterable. * docs: add @brentswisher as a contributor * chore(changelog): update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes #571 by preventing the default toaster
returnElementsvalue from being overwritten toundefinedif a toast event is created without specifying it in thepharos-toast-openevent.How does this change work?
If the
returnElementscoming from the event details isundefinedit will be defaulted to an empty array