Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move added resources into ready for git commit resoure group #926

Merged
merged 8 commits into from
Oct 19, 2021

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 19, 2021

2/3 master <- #928 <- this <- #927

Makes more sense to have Added resources in the Ready For Git Commit group because the placeholder is ready to commit into git.

Screenshot:

image

@mattseddon mattseddon added the product PR that affects product label Oct 19, 2021
@mattseddon mattseddon self-assigned this Oct 19, 2021
@mattseddon mattseddon force-pushed the move-added-into-ready-to-commit branch from 1439197 to 8e4843e Compare October 19, 2021 05:51
@mattseddon mattseddon changed the base branch from master to wait-for-test-to-call October 19, 2021 05:52
@mattseddon mattseddon marked this pull request as ready for review October 19, 2021 06:01
Base automatically changed from wait-for-test-to-call to master October 19, 2021 18:42
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2021

Code Climate has analyzed commit a01f684 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 7504ce9 into master Oct 19, 2021
@mattseddon mattseddon deleted the move-added-into-ready-to-commit branch October 19, 2021 19:28
@mattseddon
Copy link
Member Author

Relates to #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants