Focus commit input box after SCM commit action #859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From talking with Alexander yesterday I think that we want to cut down the number of clicks / actions to get users through particular workflows.
In the SCM view we currently have a
commit
button which runsdvc commit
(for the entire repository) but then stops. In this PR I have made the cursor jump to thegit
commitinputBox
once the user hasdvc commit
ted theirDVC
changes. This should serve to educate users that they still have to enter a commit message and commit togit
once they have rundvc commit
.Thought process for this going with this approach:
git.enableSmartCommit
option then it is fairly quick.IMO if you watched a 30 second video explaining the flow it would make the whole process / underlying DVC semantics more intuitive. LMK what you think.
Demos
Without
git.enableSmartCommit
(this can be enabled by clicking "always" from the second popup):Screen.Recording.2021-09-30.at.11.16.13.am.mov
With
git.enableSmartCommit
:Screen.Recording.2021-09-30.at.11.17.46.am.mov
Relates to #609.