Add basic rename command to tracked explorer tree (move) #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Sep 8, 2021
| "command": "dvc.pushTarget", | ||
| "group": "DVC", | ||
| "command": "dvc.pullTarget", | ||
| "group": "1_DVC@1", |
There was a problem hiding this comment.
[F] The context menu is now ordered as follows:
… add-rename-command
|
Code Climate has analyzed commit 3022153 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
rogermparent
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
master<- this <- #795This PR adds the option to rename a file in the explorer tracked tree based on dvc move.
Things to note:
renameFileaction as it works very unexpectedly when I wired it up to the tree.showInputBoxas the best alternative. I am open to suggestions for how to improve this.Demo:
Screen.Recording.2021-09-08.at.2.07.30.pm.mov
In the next PR I am going to move around how we use
showGenericErroras I think that we can tie this into our newregisterInstrumentedCommandfunctionality.Addresses part of the 3rd point on #569.