Upgrade extension telemetry package #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
upgrade-telemetry
branch
2 times, most recently
from
f4b1c94 to
830e462
Compare
shcheklein
approved these changes
Dec 7, 2024
mattseddon
force-pushed
the
upgrade-telemetry
branch
from
830e462 to
ba92e4d
Compare
|
Code Climate has analyzed commit ba92e4d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.8% (0.0% change). View more on Code Climate. |
|
I built and installed the extension locally and it seems to be sending events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to upgrade this package to
0.9.0resulted in all events being dropped before they arrived in application insights but we didn't try to use the connection string last time (see microsoft/vscode-extension-telemetry#192 for some more details).#5849 may be caused by the fact we are running an old version of Telemetry that is no longer compatible with the current version of VS Code.