Add copy file path action to Tracked Explorer Tree #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
copy-file-path-command
branch
from
788312e to
bcdd078
Compare
mattseddon
commented
Jun 18, 2021
| export const reRegisterVsCodeCommands = (disposer: Disposer) => { | ||
| disposer.track( | ||
| commands.registerCommand('dvc.copyFilePath', path => | ||
| commands.executeCommand('copyFilePath', Uri.file(path)) |
There was a problem hiding this comment.
[F] I tried to simply reference this in our package json and it could not be found so looks like we need to wrap it.
mattseddon
commented
Jun 18, 2021
| @@ -50,6 +50,11 @@ suite('Extension Test Suite', () => { | |||
| }) | |||
|
|
|||
| describe('TrackedExplorerTree', () => { | |||
| it('should be able to run dvc.copyFilePath without error', async () => { | |||
| expect(await commands.executeCommand('dvc.copyFilePath', dvcDemoPath)).not | |||
| .to.Throw | |||
There was a problem hiding this comment.
[F] The original command returns undefined and I have not one single idea of how get to something off the clipboard and into this test 😢
mattseddon
commented
Jun 18, 2021
| await commands.executeCommand('workbench.action.files.newUntitledFile') | ||
| await commands.executeCommand('editor.action.clipboardPasteAction') | ||
|
|
||
| expect(window.activeTextEditor?.document.getText()).to.equal(dvcDemoPath) |
There was a problem hiding this comment.
#570 (comment) and 40 minutes later we have this.... 🤯
rogermparent
approved these changes
Jun 18, 2021
|
Code Climate has analyzed commit a61a981 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to address #569.
Adds Copy Path to the tracked explorer tree context menu, whilst keeping it hidden from the command palette.
Demo:
Screen.Recording.2021-06-18.at.3.47.07.pm.mov
If we're happy with the code structure / approach then I'll start rolling on this feature.