Replace switch statements that feed the webviews stores #5194
Conversation
mattseddon
force-pushed
the
update-switch
branch
from
7a6c19c to
b34cd92
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| dispatch(update(!!data.data)) | ||
|
|
||
| for (const key of Object.keys(data.data)) { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
webview/src/setup/components/App.tsx
Outdated
|
|
||
| default: | ||
| continue | ||
| for (const key of Object.keys(data.data)) { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
mattseddon
force-pushed
the
update-switch
branch
from
70006c1 to
c16cf0b
Compare
| @@ -1,19 +1,19 @@ | |||
| import React, { useCallback } from 'react' | |||
| import { useDispatch } from 'react-redux' | |||
| import { TableData } from 'dvc/src/experiments/webview/contract' | |||
There was a problem hiding this comment.
During the creation of this PR I moved the reducers in and out of this file. Rather than struggle to revert the exact order I resorted to using VS Code's "Organize Imports":
Rather than fight the new order I think we should start using this (means I have to think less to make things consistent).
There was a problem hiding this comment.
I used to do this, but it would clash with some linting we have. There might be a config that was needed.
| import type { PlotsActions } from '../plots/components/App' | ||
| import type { PlotsDispatch } from '../plots/store' | ||
| import type { SetupActions } from '../setup/components/App' | ||
| import type { SetupDispatch } from '../setup/store' |
There was a problem hiding this comment.
[F] Using type here to try and avoid including unnecessary code in each webview's bundle.
mattseddon
force-pushed
the
update-switch
branch
from
c0c97f2 to
c7dbea1
Compare
|
Code Climate has analyzed commit c7dbea1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.2% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Closes #5182