-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Studio" to "DVC Studio" in titles #5131
Conversation
@@ -19,7 +19,7 @@ export const Settings: React.FC< | |||
return ( | |||
<EmptyState isFullScreen={false}> | |||
<div> | |||
<h1>Studio Settings</h1> | |||
<h1>DVC Studio Settings</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated title-like text but I'm not sure if we should be referring to DVC Studio everywhere. Other places:
- in Command Pallete commands
- link description in experiments table
- toasts
- description tooltip in setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please share screenshots to review those places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on this tbh. I think it's clear from the context already. @jendefig wdyt? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe as a rule of thumb, any place it's by itself or first appearing, the instance should say "DVC Studio." If there are follow-up sentences/messaging in the same place/area it's ok to say just "Studio."
In @julieg18 instances above top to bottom:
- DVC Studio
- DVC Studio
- Studio is fine
- DVC Studio
- DVC Studio
- Studio references in the lower text are fine because the header already says "DVC Studio"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope, but this could be a variable (const STUDIO_PRODUCT_NAME = 'DVC Studio'
) that way we only have to change it once.
Not sure about needing a variable. Product names don't tend to change often 🤔 |
Code Climate has analyzed commit f8e4034 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Demo
Screen.Recording.2023-12-17.at.1.32.36.PM.mov
See message in slack thread