Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Studio" to "DVC Studio" in titles #5131

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Dec 17, 2023

Demo

Screen.Recording.2023-12-17.at.1.32.36.PM.mov

See message in slack thread

@julieg18 julieg18 added the product PR that affects product label Dec 17, 2023
@julieg18 julieg18 self-assigned this Dec 17, 2023
@@ -19,7 +19,7 @@ export const Settings: React.FC<
return (
<EmptyState isFullScreen={false}>
<div>
<h1>Studio Settings</h1>
<h1>DVC Studio Settings</h1>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated title-like text but I'm not sure if we should be referring to DVC Studio everywhere. Other places:

  • in Command Pallete commands
  • link description in experiments table
  • toasts
  • description tooltip in setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please share screenshots to review those places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Here are other places where we mention "Studio":

image image image image image image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this tbh. I think it's clear from the context already. @jendefig wdyt? :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe as a rule of thumb, any place it's by itself or first appearing, the instance should say "DVC Studio." If there are follow-up sentences/messaging in the same place/area it's ok to say just "Studio."

In @julieg18 instances above top to bottom:

  1. DVC Studio
  2. DVC Studio
  3. Studio is fine
  4. DVC Studio
  5. DVC Studio
  6. Studio references in the lower text are fine because the header already says "DVC Studio"

@julieg18 julieg18 marked this pull request as ready for review December 17, 2023 19:36
@julieg18 julieg18 requested a review from shcheklein December 17, 2023 19:36
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope, but this could be a variable (const STUDIO_PRODUCT_NAME = 'DVC Studio') that way we only have to change it once.

@julieg18
Copy link
Contributor Author

Out of scope, but this could be a variable (const STUDIO_PRODUCT_NAME = 'DVC Studio') that way we only have to change it once.

Not sure about needing a variable. Product names don't tend to change often 🤔

@julieg18 julieg18 enabled auto-merge (squash) December 20, 2023 16:19
Copy link

codeclimate bot commented Dec 20, 2023

Code Climate has analyzed commit f8e4034 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 7258674 into main Dec 20, 2023
8 checks passed
@julieg18 julieg18 deleted the studio-to-dvc-studio branch December 20, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants