Fix e2e tests (SCM entry removed by insiders) #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Nov 6, 2023
| @@ -192,7 +192,6 @@ describe('Source Control View', function () { | |||
| // eslint-disable-next-line sonarjs/cognitive-complexity | |||
| it('should show the expected changes after running an experiment', async function () { | |||
| const expectedScmItemLabels = [ | |||
| 'demo DVC', | |||
There was a problem hiding this comment.
This was removed in the lastest VS Code insiders release.
There was a problem hiding this comment.
We also shouldn't need this to be present for the test to pass. My bad.
julieg18
approved these changes
Nov 6, 2023
sroy3
approved these changes
Nov 6, 2023
mattseddon
force-pushed
the
fix-e2e-tests
branch
2 times, most recently
from
152efe8 to
9603eae
Compare
mattseddon
force-pushed
the
fix-e2e-tests
branch
from
9603eae to
e74081f
Compare
|
Code Climate has analyzed commit e74081f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.