Add Setup Studio module #4943
Merged
Add Setup Studio module #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julieg18
commented
Nov 2, 2023
julieg18
commented
- Moved studio-related setup code into its own module in preparation for Add Studio Token Auth Flow #4931
julieg18
commented
Nov 2, 2023
extension/src/setup/studio.ts
Outdated
| private studioIsConnected = false | ||
| private shareLiveToStudio: boolean | undefined = undefined | ||
| private readonly getCwd: () => string | undefined | ||
| private readonly internalCommands: InternalCommands |
There was a problem hiding this comment.
This class would be handling token requests and responses when we implement Studio token authentication.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| private accessConfig(cwd: string, ...args: Args) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mattseddon
reviewed
Nov 5, 2023
mattseddon
approved these changes
Nov 5, 2023
sroy3
approved these changes
Nov 6, 2023
|
Code Climate has analyzed commit 3a5bc6f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 88.2% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.