Warn user before trying to add a stage to their pipeline #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 20, 2023
mattseddon
force-pushed
the
warn-before-adding-stage
branch
from
3b413f1 to
593154b
Compare
sroy3
approved these changes
Oct 23, 2023
mattseddon
force-pushed
the
warn-before-adding-stage
branch
from
593154b to
d7915b0
Compare
|
Code Climate has analyzed commit d7915b0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this feedback:
"
When you click Add Plot -> Data Series it opens the Finder where you can select files. In my case doesn’t work 😞 I see the next prompt like below. Do you know why is it difference?
"
Demo
Screen.Recording.2023-10-23.at.10.36.52.am.mov
Note: As demonstrated above this modal will be shown any time that a user tries to perform an action without a stage except adding the stage from the experiments webview.