Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove banner from README #4795

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove banner from README #4795

merged 1 commit into from
Oct 10, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 9, 2023

This is what users currently see when they visit the marketplace listing/GH:

Screenshot 2023-10-10 at 9 19 07 am

image

Removing the banner will bring the GIF into view. LMK what you think.

@mattseddon mattseddon self-assigned this Oct 9, 2023
@mattseddon mattseddon marked this pull request as ready for review October 9, 2023 22:20
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Most marketplace extensions I see don't have a banner at the top either.

demo Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is meant to be here.

@mattseddon mattseddon enabled auto-merge (squash) October 10, 2023 19:57
@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit 89b1e83 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0%.

View more on Code Climate.

@mattseddon mattseddon merged commit 8628c1b into main Oct 10, 2023
@mattseddon mattseddon deleted the remove-banner branch October 10, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants