Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "No Plots" section message #4793

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Update "No Plots" section message #4793

merged 3 commits into from
Oct 17, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 9, 2023 •
edited
Loading

@julieg18 julieg18 added the product PR that affects product label Oct 9, 2023
@julieg18 julieg18 self-assigned this Oct 9, 2023
@julieg18 julieg18 marked this pull request as ready for review October 9, 2023 22:16
@mattseddon mattseddon requested a review from shcheklein October 9, 2023 22:16
@mattseddon
Copy link
Member

Defer to @shcheklein

sroy3
sroy3 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my personal opinion, I'd add a new line for the new text. Shorter lines are easier to read.

@shcheklein
Copy link
Member

Thanks @julieg18 !

Let's be super explicit here:

No plots or data to display.
Note: If you have some experiments selected that just started you might need to wait while data to plot is produced. The screen will be updated automatically if plots are setup correctly in this case.

Also, let's please review some other places where we have a similar message.

@julieg18
Copy link
Contributor Author

Thanks @julieg18 !

Let's be super explicit here:

No plots or data to display. Note: If you have some experiments selected that just started you might need to wait while data to plot is produced. The screen will be updated automatically if plots are setup correctly in this case.

Also, let's please review some other places where we have a similar message.

Updated the title and added the additional message in empty plot sections:

image image image

cc @shcheklein

@julieg18 julieg18 requested a review from sroy3 October 16, 2023 15:21
@shcheklein
Copy link
Member

Look good to me, thanks @julieg18 !

@mattseddon mattseddon enabled auto-merge (squash) October 17, 2023 00:01
@codeclimate
Copy link

codeclimate bot commented Oct 17, 2023

Code Climate has analyzed commit f658319 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 8e6739e into main Oct 17, 2023
3 checks passed
@mattseddon mattseddon deleted the update-no-plots-message branch October 17, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattseddon mattseddon mattseddon approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein shcheklein is a code owner

@sroy3 sroy3 Awaiting requested review from sroy3

Assignees

@julieg18 julieg18

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve message when plots are created for the first time
4 participants
@julieg18 @mattseddon @shcheklein @sroy3