Handle pull requests from forks #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
handle-fork
branch
from
e29d4f3 to
0159298
Compare
mattseddon
commented
Oct 4, 2023
| @@ -42,16 +42,25 @@ jobs: | |||
|
|
|||
| - run: yarn run lint | |||
|
|
|||
| - uses: paambaati/[email protected] | |||
| - name: Run Coverage Report | |||
There was a problem hiding this comment.
This is the easiest way to bypass uploading a coverage report/storybook for pull requests from a fork. There would be value in getting both reports but the effort required to set that up along with the potential security risk (if we added extra secrets/forget) makes this the logical choice for now IMO.
|
The other route is along the lines of #2644 |
sroy3
approved these changes
Oct 4, 2023
mattseddon
force-pushed
the
handle-fork
branch
from
0159298 to
af24868
Compare
|
Code Climate has analyzed commit af24868 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #4616
The continuous integration workflow will currently always fail for forked pull requests. This is due to secrets not being passed to forks.
Comments inline.
If we start getting a lot of outside contributions then we can revisit.