Collapse duplicate rows when table is flattened #4735
Conversation
There was a problem hiding this comment.
Updated our sorting fixture to have multiple branches:
mainwith 5 commits and seven experiments under oneother-branchwith one commit and no experimentsanother-branchwith one commit and no experiments
| @@ -183,46 +183,69 @@ describe('App', () => { | |||
| await expectHeaders(['A', 'C', 'D', 'B']) | |||
| }) | |||
|
|
|||
| it('should add a "branch/tags" column if the table is sorted', () => { | |||
| renderTable(sortedTableStateFixture) | |||
| describe('Sorted (Flattened) Table', () => { | |||
There was a problem hiding this comment.
Grouped the "parents" column tests inside of a describe block.
| > | ||
| <div className={styles.cellContents}> | ||
| <Icon icon={GitMerge} width={13} height={13} /> | ||
| <ul |
There was a problem hiding this comment.
We could also use span but chose ul/li for accessibility.
|
@julieg18 please rebase when you get a chance. I'll review afterwards. |
Done :) |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| } = cell as unknown as CellContext<Experiment, CellValue> | ||
|
|
||
| if (!branch) { | ||
| if (flatBranches.length === 0) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Deeply nested sorting story needs to be updated :) |
|
Code Climate has analyzed commit f819ec9 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
Demo
Screen.Recording.2023-09-28.at.12.24.37.PM.mov
Part of #4746