Move all state reponsibility inside of RepositoryState #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 955878c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 94.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.1% (0.0% change). View more on Code Climate. |
This was referenced May 24, 2021
mattseddon
commented
May 24, 2021
| public new: Set<string> = new Set() | ||
| public notInCache: Set<string> = new Set() | ||
| public tracked: Set<string> = new Set() | ||
| public untracked: Set<string> = new Set() |
There was a problem hiding this comment.
[C] Matches the style that we agreed to a couple of weeks ago.
rogermparent
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/5
master<- this <- #464 <- #465 <- #466 <- #467The purpose of this chain is to update the logic used by the Repository class to derive each tracked paths status. I will detail the change in logic on #466.
Short description of each PR is shown below:
This - PR moves more responsibility to the
RepositoryStateclass.#464 - Moves the class into it's own file.
#465 - Updates the available statuses: new is renamed to added and renamed & stageModified are added.
#466 - Uses
diffto drive the majority of statuses.#467 - refactors the internals of
RepositoryState.