Add ability to zoom and pan plots when zoomed #4629
Conversation
mattseddon
force-pushed
the
add-plot-zoom-and-pan
branch
from
30cce00
to
18326be
Compare
| const hasSmoothing = | ||
| isTemplatePlot && | ||
| (props.spec as { params?: { name: string }[] }).params?.[0]?.name === | ||
| 'smooth' |
There was a problem hiding this comment.
[C] This is pretty brittle but will do for now. Will discuss at the next cross-team whether or not we want to push this back in to dvc-render.
There was a problem hiding this comment.
worst case scenario - if the spec changes then makePlotZoomOnWheel will fall through to the default. The zoom/pan behaviour won't work but the template will still render.
|
Looks great! Let go for it (and can we add it to Studio?) QQ - are there other ways to control it? A square box selection? (can be then easier to enable on the main dashboard?) |
Do you want me to add this to Studio?
I have been through the docs and this seems like the only option without trying to directly access d3 (like tensorboard does) so there is not a simple way to "do the same thing as tensorboard". Brush zoom looks like this or this (note v4) as usual there is an open issue vega/vega-lite#4742. |
mattseddon
force-pushed
the
add-plot-zoom-and-pan
branch
from
18326be
to
8c33835
Compare
|
Code Climate has analyzed commit 8c33835 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Closes #4530
Related to iterative/dvc-render#7
This PR adds the ability to zoom (using the mouse wheel) and pan plots when they are focused. I have limited the change to only focused because it mitigates the unexpected behaviour of the plot being zoomed when the user is trying to scroll between plots.
Types covered by this change?:
What's not covered:
Demo
Screen.Recording.2023-09-07.at.11.49.54.am.mov
Note: has the potential to break custom templates.