Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide shareable links for all experiments found on Studio #4600

Merged
merged 9 commits into from
Sep 4, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 31, 2023

Depends on https://github.com/iterative/studio/pull/7332 - pending release.

Closes #3574

Demo

Screen.Recording.2023-09-05.at.8.14.11.am.mov

@mattseddon mattseddon added the product PR that affects product label Aug 31, 2023
@mattseddon mattseddon self-assigned this Aug 31, 2023
@mattseddon mattseddon marked this pull request as ready for review September 1, 2023 03:51
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon
Copy link
Member Author

There is a timing issue with experiments being pushed to Studio and them becoming available via the API. I will fix the issue in a follow up as I would like to have another set of eyes on the solution.

@mattseddon mattseddon enabled auto-merge (squash) September 4, 2023 22:51
@codeclimate
Copy link

codeclimate bot commented Sep 4, 2023

Code Climate has analyzed commit d9c3cc5 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 91.5% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 9b55012 into main Sep 4, 2023
@mattseddon mattseddon deleted the use-new-api branch September 4, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the new DVC sharing experiments workflow and unify it with VS Code
2 participants