Remove click listener from experiment name and sha #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Aug 20, 2023
| testClick(screen.getByText('[exp-e7a67]'), 'exp-e7a67') | ||
| }) | ||
|
|
||
| it('should send a message to the extension to toggle an experiment when Enter or Space is pressed on the row', () => { |
There was a problem hiding this comment.
[F] I spent 20-30 minutes trying to fix this test but could not come up with anything that worked. The behaviour does work.
There was a problem hiding this comment.
Maybe I'm misunderstanding this feature, but when I tabbed onto a table row and pressed enter/space nothing was toggled 🤔
There was a problem hiding this comment.
Focus needs to be on the plot icon. I'll record a demo later
There was a problem hiding this comment.
Screen.Recording.2023-08-22.at.8.00.05.am.mov
julieg18
approved these changes
Aug 21, 2023
|
Code Climate has analyzed commit c8fd82a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4534
Demo
Screen.Recording.2023-08-21.at.8.25.02.am.mov