Use diff in repository class #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
May 20, 2021
…code-dvc into switch-repo-to-diff
… switch-repo-to-diff
mattseddon
commented
May 20, 2021
| { 'changed deps': { 'data/MNIST': 'modified' } }, | ||
| { 'changed outs': { 'model.pt': 'modified', logs: 'modified' } }, | ||
| 'always changed' | ||
| const mockDiff = stub(CliReader, 'diff').resolves({ |
There was a problem hiding this comment.
[F] This is straight dump from the CLI
mattseddon
commented
May 20, 2021
extension/src/cli/reader.ts
Outdated
| > | ||
|
|
||
| export const status = (options: ExecutionOptions): Promise<Status> => | ||
| readCliProcessJson<Status>(options, Command.STATUS) |
There was a problem hiding this comment.
[C] Dithered a bit on whether to remove this or not as "we'll need it later" but it doesn't have a test AND just follow YAGNI, it's in the commit history.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| if (this.state.notInCache?.has(uri.fsPath)) { | ||
| return DecorationProvider.DecorationNotInCache | ||
| } | ||
| if (this.state.modified?.has(uri.fsPath)) { | ||
| return DecorationProvider.DecorationModified | ||
| } | ||
| if (this.state.stageModified?.has(uri.fsPath)) { | ||
| return DecorationProvider.DecorationStageModified |
There was a problem hiding this comment.
Avoid too many return statements within this function.
|
Code Climate has analyzed commit 7f374d2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.1% (0.0% change). View more on Code Climate. |
|
split this up into reviewable chunks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to take a look at what is here but it is very rough (so that I could demo the approach in this #318 (comment)).
I am going to break bits off of this to make it easier to review.
diffhas anaddedstatus as opposed tonewso I switched across to use that.I will add
renamedinto the dependent classes in a subsequent PR.