Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff command (for use in trees) #449

Merged
merged 4 commits into from
May 20, 2021
Merged

Add diff command (for use in trees) #449

merged 4 commits into from
May 20, 2021

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 20, 2021

Start of work detailed here: #318 (comment).

@mattseddon mattseddon added the product PR that affects product label May 20, 2021
@mattseddon mattseddon self-assigned this May 20, 2021
'not in cache': Path[]
}

export const diff = (options: ExecutionOptions): Promise<DiffOutput> =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented May 20, 2021

Code Climate has analyzed commit ac35acc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.7% (0.1% change).

View more on Code Climate.

@mattseddon mattseddon marked this pull request as ready for review May 20, 2021 04:40
@mattseddon mattseddon requested a review from rogermparent May 20, 2021 04:41
@mattseddon mattseddon merged commit 93d3d1a into master May 20, 2021
@mattseddon mattseddon deleted the add-dvc-diff branch May 20, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants