Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter icon in experiment table column header cells #4406

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 3, 2023

This PR updates the icon used to indicate the experiments table has been filtered by a column. The icon now matches the filters icon in the <Indicators/> component.

Before

Screenshot 2023-08-03 at 2 47 09 pm

After

Screenshot 2023-08-03 at 2 46 50 pm

@mattseddon mattseddon self-assigned this Aug 3, 2023
@mattseddon mattseddon changed the title Update filter icon in column header cells Update filter icon in experiment table column header cells Aug 3, 2023
@mattseddon mattseddon marked this pull request as ready for review August 3, 2023 07:04
@mattseddon mattseddon enabled auto-merge (squash) August 3, 2023 22:08
@codeclimate
Copy link

codeclimate bot commented Aug 3, 2023

Code Climate has analyzed commit 5fab5cb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 108f11b into main Aug 3, 2023
@mattseddon mattseddon deleted the update-filter-icon branch August 3, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants