Collect webview messages async #4405
Conversation
| stub(dvcReader, 'dag').resolves('') | ||
|
|
||
| const pipeline = buildExperimentsPipeline({ | ||
| const { experiments, messageSpy } = await buildExperimentsWebview({ |
There was a problem hiding this comment.
[F] After reading this test I had no idea why it didn't use the builder so moved it across.
|
|
||
| messageSpy.resetHistory() | ||
|
|
||
| const movedGroup = 'params:params.yaml' | ||
|
|
||
| const tableChangePromise = experimentsUpdatedEvent(experiments) | ||
| const messageSent = waitForSpyCall(messageSpy, messageSpy.callCount) |
There was a problem hiding this comment.
[F] I had to add this new util as the data for the message is now gathered async.
There was a problem hiding this comment.
Where possible we still rely on the old util (experimentsUpdatedEvent(experiments))
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const selectedColumns = this.columns.getSelected() | ||
|
|
||
| const showOnlyChanged = this.columns.getShowOnlyChanged() | ||
| private async getWebviewData(): Promise<TableData> { |
There was a problem hiding this comment.
Function getWebviewData has 62 lines of code (exceeds 40 allowed). Consider refactoring.
mattseddon
force-pushed
the
collect-message-async
branch
from
eadc12e to
3251d1d
Compare
mattseddon
force-pushed
the
collect-message-async
branch
from
3251d1d to
6096ba7
Compare
mattseddon
changed the title
| selectedRevisions, | ||
| template: this.getTemplatePlots(selectedRevisions) | ||
| }) | ||
| const webview = this.getWebview() |
There was a problem hiding this comment.
[F] although this function is duplicated it is not worth the hassle that a base class would bring
mattseddon
force-pushed
the
collect-message-async
branch
from
6096ba7 to
52b45dd
Compare
| @@ -68,9 +68,13 @@ export class WebviewMessages { | |||
| this.update = update | |||
| } | |||
|
|
|||
| public sendWebviewMessage() { | |||
| public async sendWebviewMessage() { | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit d880a15 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
Follow up to #4402 (comment)
This PR makes the collection of experiments and plots webview messages async.