Fix DVC setup showing false info on incompatible global DVC #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* keeps section (and extension status) showing accurate information when extension auto selects a global version of DVC
julieg18
commented
May 23, 2023
| @@ -485,8 +485,9 @@ describe('run', () => { | |||
| await flushPromises() | |||
| expect(mockedWarnWithOptions).toHaveBeenCalledTimes(1) | |||
| expect(mockedWarnWithOptions).toHaveBeenCalledWith( | |||
| 'The extension cannot initialize because the DVC CLI version is incompatible.', | |||
There was a problem hiding this comment.
This bug and incorrectly written test was introduced in #3784 when I simplified the discovery.ts logic.
| } | ||
|
|
||
| setup.unsetPythonBinPath() | ||
|
|
||
| return processVersionDetails( |
There was a problem hiding this comment.
We only set DVC as global if the found version is compatible so we shouldn't be processing global DVC version details unless we're setting DVC as global. Else we need to process python environment details.
julieg18
changed the title
mattseddon
approved these changes
May 23, 2023
|
Code Climate has analyzed commit 3c24d4d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Demo environment details: I have a
MIN_CLI_VERSIONof2.58.0(updated for test so I could easily test global DVC incompatibility), a global DVC installation of2.57.0, and a selected python environment with no DVC.main
PR
Part of #3878