Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DVCLive reference to Experiments "Setup Complete" #3948

Merged
merged 4 commits into from
May 23, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented May 22, 2023

Demo

image

Part of #3434

@julieg18 julieg18 added the product PR that affects product label May 22, 2023
@julieg18 julieg18 self-assigned this May 22, 2023
@julieg18 julieg18 marked this pull request as ready for review May 22, 2023 16:45
@julieg18 julieg18 requested review from mattseddon and sroy3 as code owners May 22, 2023 16:45
@julieg18 julieg18 requested a review from shcheklein May 22, 2023 16:46
@shcheklein
Copy link
Member

@julieg18 could you please check that the snippets also up to date with what we have in docs please

@shcheklein
Copy link
Member

what happens with the page when there are no data yet?

@julieg18
Copy link
Contributor Author

@julieg18 could you please check that the snippets also up to date with what we have in docs please

They appear to be up to date, though our code example of huggingface is a bit more simplified:

Docs:

from dvclive.huggingface import DVCLiveCallback

...

 trainer = Trainer(
    model, args,
    train_dataset=train_data,
    eval_dataset=eval_data,
    tokenizer=tokenizer,
    compute_metrics=compute_metrics,
)
trainer.add_callback(DVCLiveCallback())
trainer.train()

VSCode:

from dvclive.huggingface import DVCLiveCallback

...

trainer.add_callback(DVCLiveCallback(save_dvc_exp=True))
trainer.train()

I think our simplified version gets the point across though.

@julieg18
Copy link
Contributor Author

julieg18 commented May 22, 2023

what happens with the page when there are no data yet?

The user will see this:

image

For the record, this pr currently does not alter the "No Data" section at all :)

@shcheklein
Copy link
Member

Thanks, yes, it was more as reminder for me. I think this PR is good.

@julieg18 julieg18 enabled auto-merge (squash) May 23, 2023 14:38
@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 269d300 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 48faf35 into main May 23, 2023
@julieg18 julieg18 deleted the add-dvclive-ref-to-experiments-complete branch May 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants