Add available codicons to Storybook #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
Merged
|
Code Climate has analyzed commit 0811592 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.0% change). View more on Code Climate. |
julieg18
approved these changes
May 12, 2023
sroy3
added a commit
that referenced
this pull request
May 12, 2023
* Automatically add new icons to the icons story in Storybook * Add available codicons to Storybook (#3874)
sroy3
added a commit
that referenced
this pull request
May 12, 2023
sroy3
added a commit
that referenced
this pull request
May 12, 2023
* Cleaned up svg icons * Read and transform svg icons from list (#3872) * Read and transform svg icons from list * Apply review comments * Automatically add new icons to the icons story in Storybook (#3873) * Automatically add new icons to the icons story in Storybook * Add available codicons to Storybook (#3874)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4/4 main <= #3871 <= #3872 <= #3873 <= this
Last step of #3848
No need to add a story of available codicons as they are not yet (all) in our codebase and there is already a page that list them all. Thought it'd be nice to link to that page so that it makes things easier when chosing an icon (pick one available or copy a codicon one).