Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage path ignore patterns #3859

Merged
merged 2 commits into from
May 10, 2023
Merged

Update coverage path ignore patterns #3859

merged 2 commits into from
May 10, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 10, 2023

I wrote a test for #3857 and the coverage actually went down 😬 🙃. I think that there are some issues with the way we exclude from test coverage. I've updated the various configs to try and fix them up.

@mattseddon mattseddon force-pushed the update-jest-exclude branch from b9f0cda to 919c319 Compare May 10, 2023 08:09
@mattseddon mattseddon changed the title Update Jest's coverage path ignore patterns Update coverage path ignore patterns May 10, 2023
@mattseddon mattseddon marked this pull request as ready for review May 10, 2023 08:52
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 10, 2023 08:52
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked

This pull request will bring the total coverage in the repository to 94.9% (0.1% change).

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon enabled auto-merge (squash) May 10, 2023 21:55
@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 545b20e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.9% (0.2% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 91230d4 into main May 10, 2023
@mattseddon mattseddon deleted the update-jest-exclude branch May 10, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants