Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call exp show with multiple branches #3827

Merged
merged 15 commits into from
May 16, 2023
Merged

Call exp show with multiple branches #3827

merged 15 commits into from
May 16, 2023

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented May 4, 2023

For #1966

Demo

Screen.Recording.2023-05-11.at.12.32.56.PM.mov

Looks worse than it is, most changes are simply fixture change.
Table UI is out of scope, but happy to work on it as a follow up.

@sroy3 sroy3 added the product PR that affects product label May 4, 2023
@sroy3 sroy3 self-assigned this May 4, 2023
@sroy3 sroy3 marked this pull request as ready for review May 11, 2023 16:35
@sroy3 sroy3 requested review from mattseddon and julieg18 as code owners May 11, 2023 16:35
@mattseddon
Copy link
Member

I will get to this over the weekend 🙏🏻.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

extension/src/test/fixtures/expShow/survival/rows.ts Outdated Show resolved Hide resolved
extension/src/cli/git/reader.ts Outdated Show resolved Hide resolved
extension/src/experiments/data/index.ts Show resolved Hide resolved
extension/src/experiments/data/index.ts Outdated Show resolved Hide resolved
extension/src/experiments/model/collect.ts Outdated Show resolved Hide resolved
extension/src/experiments/model/collect.ts Outdated Show resolved Hide resolved
extension/src/experiments/workspace.ts Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit 52e0f03 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.8% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 1047e7a into main May 16, 2023
@sroy3 sroy3 deleted the exp-show-multiple-branches branch May 16, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants