Wait for config to be ready before accessing values #3799
Conversation
| @@ -577,7 +577,7 @@ suite('Setup Test Suite', () => { | |||
| mockExecuteCommand.restore() | |||
| mockRunSetup.restore() | |||
| stub(config, 'isPythonExtensionUsed').returns(false) | |||
| stub(config, 'getPythonBinPath').resolves(join('python')) | |||
| stub(config, 'getPythonBinPath').returns(join('python')) | |||
There was a problem hiding this comment.
[F] This was the cause of these test warnings.
| @@ -389,18 +390,14 @@ export class Setup | |||
| } | |||
| } | |||
|
|
|||
| private isDVCBeingUsedGlobally() { | |||
There was a problem hiding this comment.
We append the path to python to the PATH variable for the edge case that DVC is being used as a binary but with a virtual environment.
There was a problem hiding this comment.
When I was locally testing, when I chose a global version of DVC, isPythonExtensionUsed returns true, showing the "Select Python Interpreter" on the front end:
I assumed that was just how isPythonExtensionUsed worked and added an extra check with isDVCBeingUsedGlobally, but maybe there is a bug with the function or there is something wrong about my local environment?
There was a problem hiding this comment.
because we append the virtual environment path to the PATH environment variable it is technically being used.
| @@ -374,7 +374,8 @@ export class Setup | |||
| return this.sendDataToWebview() | |||
| } | |||
|
|
|||
| public getDvcCliDetails(): DvcCliDetails { | |||
| private async getDvcCliDetails(): Promise<DvcCliDetails> { | |||
| await this.config.isReady() | |||
There was a problem hiding this comment.
[F] Need to make sure that the config has set the pythonBinPath before we try to access it.
mattseddon
force-pushed
the
fix-test-warnings
branch
from
8fefe2d to
e76244b
Compare
|
Code Climate has analyzed commit 98a89eb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.0% change). View more on Code Climate. |
I saw lots of type errors being sent to the integration test logs. After investigating I found and fixed some issues.