Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch executeDvcProcess method to protected #3770

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Apr 27, 2023

This PR changes the executeDvcProcess method from public to protected as it looks like the method was only public for testing purposes.

@mattseddon mattseddon self-assigned this Apr 27, 2023
@mattseddon mattseddon marked this pull request as ready for review April 27, 2023 04:51
@mattseddon mattseddon enabled auto-merge (squash) April 27, 2023 20:25
@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit 226f6f1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit c5a6d27 into main Apr 27, 2023
@mattseddon mattseddon deleted the make-method-protected branch April 27, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants