Watch all workspace folders for changes in dot folders #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Apr 27, 2023
| getRelativePattern(cwd, '**'), | ||
| path => this.dotFolderListener(disposer, path) | ||
| ) | ||
| for (const workspaceFolder of getWorkspaceFolders()) { |
There was a problem hiding this comment.
[F] There was a small chance of a bug here when the user has multiple workspace folders. We can easily watch multiple folders for changes.
sroy3
approved these changes
Apr 27, 2023
julieg18
approved these changes
Apr 27, 2023
|
Code Climate has analyzed commit d4a503f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this whilst working on #3768. The explanation for the change is inline.