Add CLI incompatible screen to Studio section #3763
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { EmptyState } from '../../../shared/components/emptyState/EmptyState' | ||
| import { Button } from '../../../shared/components/button/Button' | ||
|
|
||
| export const Connect: React.FC = () => { |
There was a problem hiding this comment.
Function Connect has 41 lines of code (exceeds 40 allowed). Consider refactoring.
| @@ -0,0 +1,25 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Feels like we're trying to head in the direction of splitting out components. LMK if I got this wrong.
There was a problem hiding this comment.
This is going to help greatly in keeping styles simple and easy to clean out. It'll also help with Codeclimate issues and even tests.
| @@ -0,0 +1,25 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
This is going to help greatly in keeping styles simple and easy to clean out. It'll also help with Codeclimate issues and even tests.
| onClick={saveStudioToken} | ||
| /> | ||
| <p> | ||
| {"Don't Have an account?\n"} |
There was a problem hiding this comment.
Instead of adding a line break, I would add a display: block; on the following link. (It's about content vs. style).
There was a problem hiding this comment.
this line break didn't even work. I have removed
|
Code Climate has analyzed commit 5506306 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.0% change). View more on Code Climate. |
We are moving to using
dvc configto store the Studio token. This PR fixes an upcoming edge case where the user would be able to attempt to connect to Studio without having access to the CLI.Demo
Screen.Recording.2023-04-26.at.4.06.53.pm.mov
Note: I have also split grouped the Studio setup section into its own folder and split out each of the components into their own file.