Upgrade Storybook to v7 #3744
Merged
Upgrade Storybook to v7 #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
LGTM! The only thing that seem to have changes is the font of buttons. I don't know if it's because it's inheriting something different. Maybe we want to look at its style make sure it does not get affected by outside factors, but that's somewhat out of scope and very minor.
| @@ -1,5 +1,5 @@ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-assignment */ | |||
| import { Meta, Story } from '@storybook/react/types-6-0' | |||
| import type { StoryFn, Meta } from '@storybook/react' | |||
There was a problem hiding this comment.
TIL about import type. That's really neat!
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
upgrade-storybook
branch
from
5e58129 to
043498b
Compare
mattseddon
commented
Apr 25, 2023
mattseddon
commented
Apr 26, 2023
| @@ -203,13 +203,14 @@ $badge-size: 0.85rem; | |||
| // table head styles | |||
|
|
|||
| .tableIndicators { | |||
julieg18
approved these changes
Apr 26, 2023
|
Code Climate has analyzed commit 438f8fc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the jump to v7 of Storybook. PTAL