Add custom plot to e2e test #3646
Conversation
|
Maybe the plot creation could be its own test and one for the removal of same plot. That way we could test for the count to have updated as well. |
|
Thanks for the reviews! Added another plots test that check for adding and removing custom plot, plus ensured the created custom plot gets deleted. I believe we're ready for another round of reviews! |
| await waitForDvcToFinish() | ||
| await webview.focus() | ||
|
|
||
| await waitForAllPlotsToRender(webview, 5) |
There was a problem hiding this comment.
[C] Seeing as you have made this helper you might want to make another one for checking the plots are not empty.
There was a problem hiding this comment.
Moved the code to a helper but ran into the expect-expect eslint warning. I disabled it with a comment for now but can revert the change or adjust our configuration if preferred!
There was a problem hiding this comment.
You can use a comment to update the expect function names:
/* eslint jest/expect-expect: ["error", { "assertFunctionNames": ["expect", "expectHeaders"] }] */
|
Code Climate has analyzed commit b88a339 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.0% change). View more on Code Climate. |
Part of #3373