Use commit rows in metric vs param plots #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
reviewed
Mar 28, 2023
| @@ -35,6 +35,18 @@ export const customPlotsOrderFixture: CustomPlotsOrderValue[] = [ | |||
| ] | |||
|
|
|||
| export const experimentsWithCheckpoints: ExperimentWithCheckpoints[] = [ | |||
There was a problem hiding this comment.
[Q] Is this still the best name?
There was a problem hiding this comment.
I think so since the actual function that we get the experiments from is called getExperimentsWithCheckpoints 🤔
I suppose we could call it experimentsWithCommits to make it a bit more clear :)
mattseddon
approved these changes
Mar 28, 2023
sroy3
approved these changes
Mar 28, 2023
sroy3
approved these changes
Mar 28, 2023
|
Code Climate has analyzed commit 77e9cac and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2023-03-27.at.5.18.04.PM.mov
Part of #3373