Ensure the correct fetched status is applied when overriding plot revisions #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
switch-fetch-to-false
branch
from
c934267 to
a167130
Compare
sroy3
approved these changes
Mar 27, 2023
julieg18
approved these changes
Mar 27, 2023
mattseddon
force-pushed
the
remove-single-revision-refresh
branch
from
4f37e57 to
55170d2
Compare
mattseddon
force-pushed
the
switch-fetch-to-false
branch
from
a167130 to
1ac8932
Compare
|
Code Climate has analyzed commit 1ac8932 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3555 <- thisThis PR ensures that we apply the correct fetched status to revisions when we are overriding information for running checkpoint experiments. This includes both experiments running in the workspace and from the queue.
Demo
(Workspace)
Screen.Recording.2023-03-27.at.11.47.02.am.mov
(Queue)
Screen.Recording.2023-03-27.at.12.37.03.pm.mov
Note: I have slowed down the demo project to demonstrate the behaviour.