Create custom plots when the data is requested #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* creates custom plots when the plots are requested in `getCustomPlots`
This was referenced Mar 17, 2023
sroy3
approved these changes
Mar 17, 2023
mattseddon
reviewed
Mar 19, 2023
| const values = isCheckpointValue(type) | ||
| ? getCheckpointValues(experiments, metricPath) | ||
| ? getCheckpointValues(selectedExperiments, metricPath) |
There was a problem hiding this comment.
[F] This will be the best place to push the data into the spec.
mattseddon
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3
main<= #3404 <= #3466 <= thisgetCustomPlotsinstead of creating them earlier (using all experiments/checkpoints) and filtering through the trends plot values. This reduces code complexity and improves performance.Resolves #3466 (comment)