Add show experiments button to final experiments screen #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2023
mattseddon
commented
Mar 14, 2023
| @@ -15,9 +15,8 @@ export const Icon: React.FC<IconProps> = ({ | |||
| ...other | |||
| }) => { | |||
| const I = icon | |||
| const fill = 'magenta' // This color is used to make sure we change it in CSS | |||
There was a problem hiding this comment.
[F] I think we are ok to drop this as the VS Code buttons work out of the box but happy to be corrected if you think is the wrong way to go.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <h1>{"You're all setup"}</h1> | ||
| </EmptyState> | ||
| ) | ||
| return <ProjectSetup hasData={hasData} /> |
There was a problem hiding this comment.
Avoid too many return statements within this function.
sroy3
approved these changes
Mar 14, 2023
julieg18
approved these changes
Mar 14, 2023
mattseddon
force-pushed
the
focus-section
branch
from
9b85677 to
02acd3d
Compare
mattseddon
force-pushed
the
add-show-experiments-button
branch
from
15f2a4c to
135810d
Compare
mattseddon
force-pushed
the
focus-section
branch
from
02acd3d to
f9c4f35
Compare
mattseddon
force-pushed
the
add-show-experiments-button
branch
from
135810d to
075d066
Compare
|
Code Climate has analyzed commit 075d066 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4/4
main<- #3448 <- #3452 <- #3462 <- thisRelated to #3434
This PR adds a Show Experiments™️ button to the final screen in the Experiments section of the Setup webview.
Demo
Screen.Recording.2023-03-14.at.10.01.01.pm.mov