-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the plot sizing sliders sticky #3443
Conversation
I think sliders should be part of the header with the section name (is it sticky now?). We should be trying to optimize the space here. Same as we do with buttons that control the section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement. I agree with what Ivan said. The section header should be condensed and sticky.
Side note: Stories/snapshots in Chromatic look really strange with the slider moved to the LHS.
They have to be separate as the sliders cannot be in the header when the section is collapsed. But they can behave the same way. I'll make the section header sticky as well in a follow-up. |
Can't seem to figure out why. It looks ok in Storybook and the slider was on the left on main screenshots as well. I'll try to fix this when merging inside the vertical sizer as this requires the CI to test. |
Code Climate has analyzed commit 39ec522 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (0.0% change). View more on Code Climate. |
We can hide the controls when it's collapsed. I still think it's better to take less space. It's hard to justify 3 sticky rows (ribbon + header + controls). |
I'll try to move them inside the header while making the headers sticky. |
Part of #2585
Screen.Recording.2023-03-10.at.2.31.13.PM.mov