Give Setup webview a single section #3441
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import React from 'react' | ||
| import { CliIncompatible } from './CliIncompatible' | ||
| import { CliUnavailable } from './CliUnavailable' | ||
| import { ProjectUninitialized } from './ProjectUninitialized' | ||
| import { | ||
| checkCompatibility, | ||
| initializeDvc, | ||
| initializeGit, | ||
| installDvc, | ||
| selectPythonInterpreter, | ||
| setupWorkspace, | ||
| showScmPanel | ||
| } from './messages' | ||
| import { NeedsGitCommit } from './NeedsGitCommit' | ||
| import { NoData } from './NoData' | ||
| import { EmptyState } from '../../shared/components/emptyState/EmptyState' | ||
|
|
||
| export type SetupExperimentsProps = { | ||
| canGitInitialize: boolean | undefined | ||
| cliCompatible: boolean | undefined | ||
| hasData: boolean | undefined | ||
| isPythonExtensionInstalled: boolean | ||
| needsGitInitialized: boolean | undefined | ||
| needsGitCommit: boolean | ||
| projectInitialized: boolean | ||
| pythonBinPath: string | undefined | ||
| } | ||
|
|
||
| export const SetupExperiments: React.FC<SetupExperimentsProps> = ({ | ||
|
There was a problem hiding this comment. Function |
||
| canGitInitialize, | ||
| cliCompatible, | ||
| hasData, | ||
| isPythonExtensionInstalled, | ||
| needsGitInitialized, | ||
| needsGitCommit, | ||
| projectInitialized, | ||
| pythonBinPath | ||
| // eslint-disable-next-line sonarjs/cognitive-complexity | ||
| }) => { | ||
| if (cliCompatible === false) { | ||
| return <CliIncompatible checkCompatibility={checkCompatibility} /> | ||
| } | ||
|
|
||
| if (cliCompatible === undefined) { | ||
|
There was a problem hiding this comment. Similar blocks of code found in 2 locations. Consider refactoring. |
||
| return ( | ||
| <CliUnavailable | ||
| installDvc={installDvc} | ||
| isPythonExtensionInstalled={isPythonExtensionInstalled} | ||
| pythonBinPath={pythonBinPath} | ||
| selectPythonInterpreter={selectPythonInterpreter} | ||
| setupWorkspace={setupWorkspace} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (!projectInitialized) { | ||
| return ( | ||
| <ProjectUninitialized | ||
| canGitInitialize={canGitInitialize} | ||
| initializeDvc={initializeDvc} | ||
| initializeGit={initializeGit} | ||
| needsGitInitialized={needsGitInitialized} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (needsGitCommit) { | ||
| return <NeedsGitCommit showScmPanel={showScmPanel} /> | ||
| } | ||
|
|
||
| if (hasData === undefined) { | ||
| return <EmptyState>Loading Project...</EmptyState> | ||
|
There was a problem hiding this comment. Avoid too many |
||
| } | ||
|
|
||
| if (!hasData) { | ||
| return <NoData /> | ||
|
There was a problem hiding this comment. Avoid too many |
||
| } | ||
|
|
||
| return <EmptyState>{"You're all setup"}</EmptyState> | ||
|
There was a problem hiding this comment. Avoid too many |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { MessageFromWebviewType } from 'dvc/src/webview/contract' | ||
| import { sendMessage } from '../../shared/vscode' | ||
|
|
||
| export const checkCompatibility = () => { | ||
| sendMessage({ type: MessageFromWebviewType.CHECK_CLI_COMPATIBLE }) | ||
| } | ||
|
|
||
| export const initializeGit = () => { | ||
| sendMessage({ | ||
| type: MessageFromWebviewType.INITIALIZE_GIT | ||
| }) | ||
| } | ||
|
|
||
| export const initializeDvc = () => { | ||
| sendMessage({ | ||
| type: MessageFromWebviewType.INITIALIZE_DVC | ||
| }) | ||
| } | ||
|
|
||
| export const showScmPanel = () => { | ||
| sendMessage({ type: MessageFromWebviewType.SHOW_SCM_PANEL }) | ||
| } | ||
|
|
||
| export const installDvc = () => { | ||
| sendMessage({ type: MessageFromWebviewType.INSTALL_DVC }) | ||
| } | ||
|
|
||
| export const selectPythonInterpreter = () => { | ||
| sendMessage({ type: MessageFromWebviewType.SELECT_PYTHON_INTERPRETER }) | ||
| } | ||
|
|
||
| export const setupWorkspace = () => { | ||
| sendMessage({ type: MessageFromWebviewType.SETUP_WORKSPACE }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] Should I just match the plots and experiments
<App/>s and bring redux in here now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's worth it yet for the few levels that we have and how simple the components are.