Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filter by and sort by views to the bottom and collapse for new users #3431

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 8, 2023

This PR moves the filter by and sort by trees to the bottom of our view container and collapses them for new users. I think we can do this because we have decided these are "advanced features". From the docs:

A view can also have an optional visibility property which can be set to visible, collapsed, or hidden. 
This property is only respected by VS Code the first time a workspace is opened with this view. 
After that, the visibility is set to whatever the user has chosen. 
If you have a view container with many views, or if your view will not be useful to every user of your extension, consider setting the view the collapsed or hidden. 

This will be the screen that a new user sees when they get setup for the first time:

image

For comparison, Gitlens collapses all of the views it adds to the SCM tree. I only expand them when I use them. E.g:

Screen.Recording.2023-03-09.at.8.57.14.am.mov

[Q] Which other (if any) tree views should get the same treatment?

@mattseddon mattseddon added the product PR that affects product label Mar 8, 2023
@mattseddon mattseddon self-assigned this Mar 8, 2023
@mattseddon mattseddon marked this pull request as ready for review March 8, 2023 21:59
@mattseddon mattseddon requested a review from shcheklein March 8, 2023 21:59
@mattseddon mattseddon changed the title Move filter by and sort by views to the bottom and collapse for initial state Move filter by and sort by views to the bottom and collapse for new users Mar 8, 2023
@mattseddon mattseddon force-pushed the set-initial-view-state branch from e94e282 to 71b4e7b Compare March 8, 2023 22:05
@mattseddon mattseddon enabled auto-merge (squash) March 9, 2023 02:22
@codeclimate
Copy link

codeclimate bot commented Mar 9, 2023

Code Climate has analyzed commit 5f2498f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit faab9c7 into main Mar 9, 2023
@mattseddon mattseddon deleted the set-initial-view-state branch March 9, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants